Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the terminal shutdown issue #446

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Fix for the terminal shutdown issue #446

merged 1 commit into from
Mar 18, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Mar 17, 2021

Backport of jupyter/notebook#4180

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @afshin - thank you.

@kevin-bates
Copy link
Member

@afshin - I'm guessing the cross-site scripting issues in CodeQL must be triggered by some new detection that is flagging the examples. Would you agree? If so, I think this would be fine to merge.

@blink1073 blink1073 merged commit d690965 into jupyter-server:master Mar 18, 2021
@blink1073 blink1073 added this to the 1.5 milestone Mar 18, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants